Skip to content

refactor!: ConnectionState & Event Handling#5

Merged
Paillat-dev merged 48 commits intomasterfrom
state-rewrite
Dec 2, 2025
Merged

refactor!: ConnectionState & Event Handling#5
Paillat-dev merged 48 commits intomasterfrom
state-rewrite

Conversation

@VincentRPS
Copy link
Copy Markdown

@VincentRPS VincentRPS commented May 13, 2025

There are a lot of things here, but they should be mostly covered in the changelog.

definitely doesn't work yet, just felt like there was way too much changes not to commit already
Comment thread discord/app/cache.py
Comment thread discord/app/cache.py Outdated
Comment thread discord/app/events.py Outdated
Comment thread discord/app/cache.py Outdated
@VincentRPS VincentRPS requested a review from Paillat-dev May 15, 2025 19:54
Copy link
Copy Markdown
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try running the code yet, will do that later today

Comment thread discord/app/event_emitter.py Outdated
Comment thread discord/app/event_emitter.py Outdated
Co-authored-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: VincentRPS <vincentbusiness55@gmail.com>
@Paillat-dev
Copy link
Copy Markdown
Member

@VincentRPS You should also import defaultdict

@Paillat-dev
Copy link
Copy Markdown
Member

Any news ? See traceback of another error here:

https://canary.discord.com/channels/881207955029110855/881735314987708456/1373639761696133160

@Paillat-dev
Copy link
Copy Markdown
Member

Congrats @VincentRPS you successfully broke the docs ! 🎉

Comment thread discord/app/state.py Outdated
Comment thread discord/app/event_emitter.py
VincentRPS and others added 3 commits June 28, 2025 22:10
Co-authored-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: VincentRPS <vincentbusiness55@gmail.com>
@Paillat-dev
Copy link
Copy Markdown
Member

Paillat-dev commented Jul 29, 2025

@VincentRPS I am going to rebase this for you and push here

@VincentRPS
Copy link
Copy Markdown
Author

@VincentRPS I am going to rebase this for you and push here

M'kay!

Paillat-dev and others added 8 commits November 13, 2025 12:35
Co-authored-by: Emma Terzioglu <emreterzioglu49@gmail.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>
@Paillat-dev Paillat-dev requested a review from plun1331 November 13, 2025 11:52
@VincentRPS VincentRPS marked this pull request as ready for review November 13, 2025 12:17
@VincentRPS VincentRPS requested a review from a team as a code owner November 13, 2025 12:17
Comment thread discord/events/guild.py Outdated
Comment thread discord/events/guild.py Outdated
Comment thread discord/events/guild.py Outdated
Comment thread discord/events/guild.py
Comment thread discord/events/guild.py
Comment thread discord/events/guild.py Outdated
Comment thread discord/events/guild.py Outdated
Comment thread discord/events/guild.py Outdated
Comment thread discord/events/guild.py Outdated
Signed-off-by: Vincent Jose <vincentbusiness55@gmail.com>
Removed duplicated GuildCreate, GuildJoin, and GuildAvailable event classes from gateway.py.

Signed-off-by: Vincent Jose <vincentbusiness55@gmail.com>
Copy link
Copy Markdown
Author

@VincentRPS VincentRPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix for old threads

Comment thread discord/events/thread.py
Comment thread discord/events/thread.py Outdated
VincentRPS and others added 4 commits November 13, 2025 20:43
Signed-off-by: Vincent Jose <vincentbusiness55@gmail.com>
Signed-off-by: Vincent Jose <vincentbusiness55@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Vincent Jose <vincentbusiness55@gmail.com>
@Paillat-dev
Copy link
Copy Markdown
Member

Idk what you did but everything is failing

Signed-off-by: Paillat-dev <paillat@pycord.dev>
@Paillat-dev Paillat-dev mentioned this pull request Nov 19, 2025
@Paillat-dev
Copy link
Copy Markdown
Member

@VincentRPS we can just merge this one imo, tests are passing and I tested it and it seemingly worked. I don't see why we should be delaying anything because of this

@VincentRPS VincentRPS enabled auto-merge (squash) December 2, 2025 14:51
@VincentRPS
Copy link
Copy Markdown
Author

Time to rip the bandaid.

@Paillat-dev Paillat-dev disabled auto-merge December 2, 2025 14:52
@Paillat-dev Paillat-dev merged commit e4b48e6 into master Dec 2, 2025
23 of 24 checks passed
@Paillat-dev Paillat-dev deleted the state-rewrite branch December 2, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite a better caching system

7 participants